qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Logout existing sessions after an auth config change

Open Func86 opened this issue 1 year ago • 4 comments

Closes #18443.

Func86 avatar Sep 06 '24 18:09 Func86

UPDATE, disregard the above. It should be done in WebUI::configure() instead. This is where the server updates the configuration.

The same as currently. WebUI will have to store the previous username/password values to detect that they have changed.

glassez avatar Sep 17 '24 14:09 glassez

The same as currently. WebUI will have to store the previous username/password values to detect that they have changed.

I think the following should work:

  1. add a new signal Preferences::webCredentialsChanged()
  2. the new signal will be emitted when the webui username updated or password hash updated. (no need to compare to the old value, just emit the signal)
  3. WebApplication will connect to the signal and remove all sessions when receiving the signal.

Chocobo1 avatar Sep 17 '24 14:09 Chocobo1

I think the following should work:

  1. add a new signal Preferences::webCredentialsChanged()
  2. the new signal will be emitted when the webui username updated or password hash updated. (no need to compare to the old value, just emit the signal)
  3. WebApplication will connect to the signal and remove all sessions when receiving the signal.

It could do the job.

Closes #18443.

It also mentions some other settings besides the username and password, changing which should lead to the termination of sessions.

How about it?

glassez avatar Sep 17 '24 14:09 glassez

It also mentions some other settings besides the username and password, changing which should lead to the termination of sessions.

How about it?

Done.

Func86 avatar Sep 17 '24 16:09 Func86

just checking in about this status of this PR

luzpaz avatar Mar 22 '25 15:03 luzpaz

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

github-actions[bot] avatar Jun 28 '25 00:06 github-actions[bot]

This PR was closed because it has been stalled for some time with no activity.

github-actions[bot] avatar Jul 06 '25 00:07 github-actions[bot]