qBittorrent
qBittorrent copied to clipboard
qbittorrent
Implement double-click behavior controls for the WebUI
This PR implements double-click behavior controls for the WebUI, similar to the desktop GUI. Closes #20436.
But as I discussed in https://github.com/qbittorrent/qBittorrent/issues/20436#issuecomment-2192285880, despite the same names, this is not the same settings. Because existing options of the GUI are not applicable for the WebUI, they are implemented as independent standalone settings.
Also the settings implemented as selectors, despite having only 2 options. They actually could be implemented as check boxes instead, but:
- I think it is better to be kinda consistent with the GUI.
- Allows for more options to be easily added in the future.
Screenshot
Personally I dislike idea of storing WebUI client settings as regular qBittorrent settings. I would consider any WebUI client (including official one) as separate client application. Now I do not insist on this point of view, because we have a very large legacy in the form of shared options between regular desktop app UI and WebUI, so it requires a complete redesign.
I followed existing logic to make this. If you think this settings should be stored in browser local storage instead, I'm not against it. In fact it's even easier that way.
Ok, I made it using local storage. The implementation is very simple now.
Strange that CI didn't run..
No idea why. #21007 had the same state back then.
Fwiw, using the linuxserver/qbittorrent docker container, this option does not seem to be present. The version is currently the latest stable of 5.0.3. and I believe this has been merged since. Given this, any ideas as to why this is potentially not showing in the WebUI version here? I have attached screenshots showing that the option doesn't seem to exist as well as the about page showing the version number.
Given this, any ideas as to why this is potentially not showing in the WebUI version here?
Because it is not in release branch yet.
https://github.com/qbittorrent/qBittorrent/pull/21000#event-13401748532
Given this, any ideas as to why this is potentially not showing in the WebUI version here?
Because it is not in release branch yet. #21000 (comment)
Ah, that makes sense then as to why it doesn't exist yet. Any idea on the release time frame for 5.1 release potentially?
No, but you could use beta or nightly build / alpha tag for the official docker image.
(linuxserver image is not official by the way, you would not have support for them from the devs.)