qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Allow to set custom suffix to window title

Open Chocobo1 opened this issue 1 year ago • 8 comments

This is to allow users to differentiate qbt instances when there are multiple running. Closes #17905.

Screenshot: pic The custom suffix is set to myInstance

Chocobo1 avatar Feb 16 '24 15:02 Chocobo1

Changing the title in WebUI requires restart in order for it to be applied to GUI.

Speed in title bar in GUI and WebUI don't seem to be connected (changing one doesn't change the other). Maybe this should do the same? No opinion from me on this.

thalieht avatar Feb 16 '24 16:02 thalieht

Speed in title bar in GUI and WebUI don't seem to be connected (changing one doesn't change the other). Maybe this should do the same?

Never mind, i saw the rationale for this change is to manage multiple instances and this would be inconvenient in that case.

thalieht avatar Feb 16 '24 16:02 thalieht

Changing the title in WebUI requires restart in order for it to be applied to GUI.

I noticed it but I haven't found a non-trivial way to achieve it. Or one can re-apply it in GUI again to have the effect but it is a bit cumbersome... Also, IIRC the assumption is that WebUI and GUI won't be used at the same time (even if it is currently possible). So if each UI can have effect on their own window title then it should be fine. Hopefully that would be acceptable.

Chocobo1 avatar Feb 16 '24 16:02 Chocobo1

Changing the title in WebUI requires restart in order for it to be applied to GUI.

I noticed it but I haven't found a non-trivial way to achieve it. Or one can re-apply it in GUI again to have the effect but it is a bit cumbersome... Also, IIRC the assumption is that WebUI and GUI won't be used at the same time (even if it is currently possible). So if each UI can have effect on their own window title then it should be fine. Hopefully that would be acceptable.

IMO, WebUI should not affect GUI directly since it is actually deal with qBittorrent at the core (base) level. I would even implement it as UI independent/abstract setting, e.g. "Instance ID" or "Instance name" that is just used by one or another UI as they want. I hope you can understand the difference.

glassez avatar Feb 16 '24 16:02 glassez

I would even implement it as UI independent/abstract setting, e.g. "Instance ID" or "Instance name" that is just used by one or another UI as they want.

OK. However "Instance ID", "Instance name" is a bit too abstract to present to users. Any suggestions for the label text? maybe Custom instance ID for main window title?

Chocobo1 avatar Feb 16 '24 17:02 Chocobo1

I would even implement it as UI independent/abstract setting, e.g. "Instance ID" or "Instance name" that is just used by one or another UI as they want. I hope you can understand the difference.

Just to be clear. I'm referring the instance as qbt instance, not UI instance. So ideally different UI should show the same qbt instance id.

Chocobo1 avatar Feb 16 '24 17:02 Chocobo1

maybe Custom instance ID for main window title?

It contradicts to my suggestion.

In fact, it no longer seems to me to mention "instance ID" there, because we cannot ensure its uniqueness. So I think it could be something like a "App title suffix" and describe in tooltip the purposes for which it can be used (i.e. to distinguish app instances).

glassez avatar Feb 16 '24 17:02 glassez

PR updated, comments addressed.

Chocobo1 avatar Feb 17 '24 14:02 Chocobo1

Wouldn't it be a good idea to provide automatically generated instance name for non-default instances if there is no custom one is set? (Not in this PR, of course.)

glassez avatar Feb 25 '24 06:02 glassez

Wouldn't it be a good idea to provide automatically generated instance name for non-default instances if there is no custom one is set?

I'm not sure. Users might not be able to recognize the generated instance names.

Chocobo1 avatar Feb 27 '24 04:02 Chocobo1

Wouldn't it be a good idea to provide automatically generated instance name for non-default instances if there is no custom one is set?

I'm not sure. Users might not be able to recognize the generated instance names.

I mean, use something like a configuration name. This is supposed to be recognizable because it is set by the user himself.

glassez avatar Feb 27 '24 04:02 glassez