qBittorrent
qBittorrent copied to clipboard
Allow to set custom suffix to window title
This is to allow users to differentiate qbt instances when there are multiple running. Closes #17905.
Screenshot:
The custom suffix is set to
myInstance
Changing the title in WebUI requires restart in order for it to be applied to GUI.
Speed in title bar in GUI and WebUI don't seem to be connected (changing one doesn't change the other). Maybe this should do the same? No opinion from me on this.
Speed in title bar in GUI and WebUI don't seem to be connected (changing one doesn't change the other). Maybe this should do the same?
Never mind, i saw the rationale for this change is to manage multiple instances and this would be inconvenient in that case.
Changing the title in WebUI requires restart in order for it to be applied to GUI.
I noticed it but I haven't found a non-trivial way to achieve it. Or one can re-apply it in GUI again to have the effect but it is a bit cumbersome... Also, IIRC the assumption is that WebUI and GUI won't be used at the same time (even if it is currently possible). So if each UI can have effect on their own window title then it should be fine. Hopefully that would be acceptable.
Changing the title in WebUI requires restart in order for it to be applied to GUI.
I noticed it but I haven't found a non-trivial way to achieve it. Or one can re-apply it in GUI again to have the effect but it is a bit cumbersome... Also, IIRC the assumption is that WebUI and GUI won't be used at the same time (even if it is currently possible). So if each UI can have effect on their own window title then it should be fine. Hopefully that would be acceptable.
IMO, WebUI should not affect GUI directly since it is actually deal with qBittorrent at the core (base) level. I would even implement it as UI independent/abstract setting, e.g. "Instance ID" or "Instance name" that is just used by one or another UI as they want. I hope you can understand the difference.
I would even implement it as UI independent/abstract setting, e.g. "Instance ID" or "Instance name" that is just used by one or another UI as they want.
OK.
However "Instance ID", "Instance name" is a bit too abstract to present to users. Any suggestions for the label text? maybe Custom instance ID for main window title?
I would even implement it as UI independent/abstract setting, e.g. "Instance ID" or "Instance name" that is just used by one or another UI as they want. I hope you can understand the difference.
Just to be clear. I'm referring the instance as qbt instance, not UI instance. So ideally different UI should show the same qbt instance id.
maybe
Custom instance ID for main window title?
It contradicts to my suggestion.
In fact, it no longer seems to me to mention "instance ID" there, because we cannot ensure its uniqueness. So I think it could be something like a "App title suffix" and describe in tooltip the purposes for which it can be used (i.e. to distinguish app instances).
PR updated, comments addressed.
Wouldn't it be a good idea to provide automatically generated instance name for non-default instances if there is no custom one is set? (Not in this PR, of course.)
Wouldn't it be a good idea to provide automatically generated instance name for non-default instances if there is no custom one is set?
I'm not sure. Users might not be able to recognize the generated instance names.
Wouldn't it be a good idea to provide automatically generated instance name for non-default instances if there is no custom one is set?
I'm not sure. Users might not be able to recognize the generated instance names.
I mean, use something like a configuration name. This is supposed to be recognizable because it is set by the user himself.