qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

NSIS - Update Italian language

Open bovirus opened this issue 3 years ago • 11 comments

bovirus avatar May 25 '22 09:05 bovirus

Typo in title of commit and pull request: "italian langauge", more correct would be: "Italian language".

For consistency with other pull requests, maybe it would be better to edit and change it to: "NSIS: Update Italian language", "Update italian.nsi" or "Update Italian translation"?

PriitUring avatar May 25 '22 10:05 PriitUring

@PriitUring

Done. Thanks.

bovirus avatar May 25 '22 10:05 bovirus

IMO, this is wrong. You shouldn't insert manual linebreaks to strings.

sledgehammer999 avatar May 25 '22 17:05 sledgehammer999

@sledgehammer999

All strings where I adeed new line code are multiperiod string (not one period string).

Theorically should have new line also in master english. Have a string that is apart on on a line an second part of a second line is not elegeant and profesisonal and not help a good understanding of tehs tring. To have each period of a multuiperiod string on separate linr is mote elengant and clear.

The only exception to this is teh GUI ahs not enough space. But is not this acse.

bovirus avatar May 26 '22 05:05 bovirus

Original GUI layout

image

New language proposal

image

bovirus avatar May 26 '22 13:05 bovirus

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

github-actions[bot] avatar Jul 26 '22 00:07 github-actions[bot]

@sledgehammer999

No news about script update?

bovirus avatar Jul 26 '22 06:07 bovirus

@Chocobo1 @glassez do you think that we should allow this?

sledgehammer999 avatar Aug 04 '22 17:08 sledgehammer999

@Chocobo1 @glassez do you think that we should allow this?

No problem for me.

glassez avatar Aug 04 '22 18:08 glassez

@Chocobo1 @glassez do you think that we should allow this?

I'm fine with it.

Chocobo1 avatar Aug 05 '22 04:08 Chocobo1

If this line break is approved, then whynot update all languages together?

PriitUring avatar Aug 09 '22 03:08 PriitUring

If this line break is approved, then whynot update all languages together?

Feel free to submit a PR for it! IMO line break placement needs not be synchronized between languages.

Chocobo1 avatar Aug 11 '22 04:08 Chocobo1

@bovirus Thank you!

Chocobo1 avatar Aug 11 '22 04:08 Chocobo1