qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Row height in "previewlist" is inconsistent with similar areas like transferlist/content tab

Open xavier2k6 opened this issue 3 years ago • 2 comments

qBittorrent & operating system versions

qBittorrent: 4.4.0/4.5.0alpha1 x64 Operating system: Windows 10 Pro 21H2/2009 x64 Qt: 5.15.2/6.2.2 libtorrent-rasterbar: 1.2.15/2.0.5

What is the problem?

Row height in "previewlist" is inconsistent with similar areas like transferlist/content tab

Preview List:

previewlist

Transfer List/Content Tab:

transfer_list_content_tab

Steps to reproduce

No response

Additional context

Use QStyledItemDelegate instead of QItemDelegate for previewlistdelegate (recommended by Qt as default)

https://doc.qt.io/qt-5/qstyleditemdelegate.html#qstyleditemdelegate-vs-qitemdelegate

https://doc.qt.io/qt-6/qstyleditemdelegate.html#qstyleditemdelegate-vs-qitemdelegate

Note: previewlistdelegate was the only area left to convert over to QStyledItemDelegate from a previous PR.

It will maintain consistency throughout the program.

Log(s) & preferences file(s)

No response

xavier2k6 avatar Jan 18 '22 18:01 xavier2k6

@jagannatharjun Could you take care of this when you have a chance, please?

xavier2k6 avatar Jan 30 '22 11:01 xavier2k6

related to #12290

xavier2k6 avatar May 16 '23 15:05 xavier2k6

@glassez Is this on your to-do list?

xavier2k6 avatar Jul 19 '23 10:07 xavier2k6

@glassez Is this on your to-do list?

No, it wasn't. I did something offhand (#19340). There wasn't even time to check it out...

glassez avatar Jul 19 '23 12:07 glassez