qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Published 20 hours ago • verified publisher icon qbittorrent

Highlighted box on alternate speed button in status bar when clicked.

Open xavier2k6 opened this issue 4 years ago • 5 comments

qBittorrent & operating system versions

qBittorrent: 4.3.8 x64 Operating system: Windows 10 Pro Version 21H1 x64 (OS Build 19043.1237) Qt: 5.15.2 libtorrent-rasterbar: 1.2.14

What is the problem?

When the normal/alternative speed button is clicked in statusbar, the alternative speed icon displays like a highlighted box around it. (the normal speed icon doesn't suffer from this)

Steps to reproduce

  1. Click the speed button in status bar to change to alternative speed
  2. Observe highlighted box
  3. Click the speed button again to return to normal speed
  4. Observe highlighted box doesn't appear.

Additional context

statusbar_alt_speed_broken

The box around it (when clicked) is on previous official/master & CI builds too.

Changing m_altSpeedsBtn->setDown(true); to m_altSpeedsBtn->setDown(false); fixes this. https://github.com/qbittorrent/qBittorrent/blob/85183334063b24651b9d34c9e371ab45effdb3e8/src/gui/statusbar.cpp#L243

statusbar_alt_speed_fixed

Log(s) & preferences file(s)

No response

xavier2k6 avatar Sep 17 '21 11:09 xavier2k6

If this is intended behavior - then I will open a "Feature request" to have it removed. If it is not intended then I will be more than glad to create a PR to fix.

xavier2k6 avatar Sep 17 '21 11:09 xavier2k6

It's intended. It's supposed to show that the pushButton is clicked and it stays down, now whether the graphical effect of it succeeds to convey that impression is debatable. It also has an effect on 2 signals but i don't think we care about that https://doc.qt.io/qt-5/qabstractbutton.html#down-prop. Personally, i'd prefer to keep it.

thalieht avatar Sep 17 '21 12:09 thalieht

The normal & alterantive icons imo are just as good at representing that the desired effect is applied.....having the box removed has better consistency in the GUI & also with the box displayed it seems to have a negative impact on the alternative icon (top is clipped, see both screenshots for comparison)

xavier2k6 avatar Sep 17 '21 12:09 xavier2k6

I would request to remove this button altogether.

ghost avatar Sep 17 '21 13:09 ghost

Perhaps something like a toggle switch could be looked in to....https://stackoverflow.com/questions/14780517/toggle-switch-in-qt

xavier2k6 avatar May 27 '23 12:05 xavier2k6