pytti-notebook icon indicating copy to clipboard operation
pytti-notebook copied to clipboard

steps_per_scene is a non-obvious cap on video length

Open usergenic opened this issue 3 years ago • 2 comments

I was doing a long video render (6 minutes) and found my runs were arbitrarily stopping at around 2000 frames. After digging through the code it looks like they stopped because the steps_per_scene value was arbitrarily set to 60000 or so and I was doing 30 steps per frame.

This steps_per_scene value seems kind of non obvious to me. Consider dropping this limit at least for Video Source?

usergenic avatar Mar 22 '22 23:03 usergenic

oh okay lol just realized that even with video source an arbitrarily high number of steps_per_scene will result in near endless rendering. so what we really need is a way to calculate the steps_per_scene number based on the length of the video input.

usergenic avatar Mar 23 '22 02:03 usergenic

I like your thinking here. I don't think it should be too hard to add a setting for something like "process all frames in video source". conversely, could probably add a warning or something along those lines to alert the user if the steps per scene is too low to run the length of the video.

dmarx avatar Mar 23 '22 03:03 dmarx