Fix: Expand tilde (~) in home directory paths for GTSRB dataset
Description
This PR fixes an issue where the GTSRB dataset fails to recognize existing data when the root path contains a tilde (~) for the home directory.
Problem
Within torchvision/datasets/gtsrb.py, due to the root path not being correctly inherited from the VisionDataset class, pathlib.Path failed to automatically expand a path containing a tilde (e.g., ~/data) into its corresponding absolute home directory path (e.g., /home/username/data). Consequently, the _check_exists() method would incorrectly return False even when the dataset was already present, leading to superfluous downloads or runtime errors.
This issue was not observed in other classes, such as OxfordIIITPet, which correctly inherit and utilize the root path from the VisionDataset class.
Changes
- Rewrite to
self.rootto ensure proper inheritance from theVisonDatasetclass. - This ensures that paths like
~/data/gtsrbare correctly resolved to absolute paths
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9263
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:white_check_mark: No Failures
As of commit 3771b4706ad980086ecbd3898da9d1bf35530968 with merge base acccf86477759b2d3500f1ae1be065f7b1e409ec ():
:green_heart: Looks good so far! There are no failures yet. :green_heart:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
Hi @cynagenautes!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!