pytorch
enable decode_jpeg and encode_jpeg support privateuseone device
enable decode_jpeg and encode_jpeg support privateuseone device @Callidior @NicolasHug Please help review it
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9252
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:heavy_exclamation_mark: 1 Active SEVs
There are 1 currently active SEVs. If your PR is affected, please view them below:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
![pytorch-bot[bot] avatar](https://avatars.githubusercontent.com/in/40112?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @taozhiwei!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
![meta-cla[bot] avatar](https://avatars.githubusercontent.com/in/1425812?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @taozhiwei , can you please share more on your use case for this?
Similar to the one below https://github.com/pytorch/pytorch/pull/135338, I support decode_jpeg and encode_jpeg on the new hardware; After this PR is accepted, All hardware connected to PyTorch through privateuseone key can be more convenient to connected toTorchVision
Hi @taozhiwei , can you please share more on your use case for this?
Similar to the one below pytorch/pytorch#135338, I support decode_jpeg and encode_jpeg on the new hardware; After this PR is accepted, All hardware connected to PyTorch through privateuseone key can be more convenient to connected toTorchVision
@Callidior @NicolasHug Please help review it again,thanks!
@taozhiwei can you please share more about the use-cases you have in mind?
We currently support CPU and CUDA decoding, but CUDA decoding is explicitly enabled by passing the device parameter. It's not going through the same disaptcher-based mechanism as other torch ops do, when they depend on the input tensor's device.
So I'm a bit unclear on what this PR is trying to achieve here. What other hardware are you aiming to support? What would the user-experience look like? Thanks!
@taozhiwei can you please share more about the use-cases you have in mind?
We currently support CPU and CUDA decoding, but CUDA decoding is explicitly enabled by passing the
deviceparameter. It's not going through the same disaptcher-based mechanism as other torch ops do, when they depend on the input tensor'sdevice.So I'm a bit unclear on what this PR is trying to achieve here. What other hardware are you aiming to support? What would the user-experience look like? Thanks!
I want to support various hardware that can be registered to pytorch through PrivateUse1
when user through torch.library.define/impl register decode_jpegs_privateuseone and encode_jpegs_privateuseone ,torchvision can support privateuseone JPEG encoding and decoding