vision
vision copied to clipboard
pytorch
Improve type hints in tv_tensor.wrap
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8830
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
![pytorch-bot[bot] avatar](https://avatars.githubusercontent.com/in/40112?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @twsl!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Fix would also be included in #8817
Your naming convention is probably better than mine is in #8817 though.
Sorry folks, I don't think I can merge this. Mypy is painful enough to please (and I'll probably have to disable it entirely anyway), but I just really don't have any bandwidth to support all type-checkers out there :/
Sorry folks, I don't think I can merge this. Mypy is painful enough to please (and I'll probably have to disable it entirely anyway), but I just really don't have any bandwidth to support all type-checkers out there :/
Is there a recommended/official torchvision stubs project ? Because type checking python is crucial to my applications.
By the way, why is the type var restricted using positional arguments instead of using a bound=TVTensor
By the way, why is the type var restricted using positional arguments instead of using a
bound=TVTensor
I intended to make the typehints explicit. Yet your comment actually made me rethink the implementation. But to actually return the correct type, it would need covariant=True. mypy then throws a Cannot use a covariant type variable as a parameter [misc]. However, in this case, it would be another false-positive according to my understanding. So ignoring it would provide a more generic version.
Therefore i pushed the current version. Please correct me, if my understanding of TypeVar is wrong