tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

AOTI tutorial `CUDA_HOME`

Open bhack opened this issue 1 year ago • 8 comments

📚 The doc issue

I am trying to follow https://pytorch.org/tutorials/recipes/torch_export_aoti_python.html but it seems it doesn't work on our nightly runtime images cause missing CUDA_HOME.

Suggest a potential alternative/fix

No response

cc @svekars @brycebortree @sekyondaMeta @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4 @desertfire @chenyang78

bhack avatar Nov 06 '24 19:11 bhack

/cc @agunapal @angelayi @svekars it is working only with devel image

bhack avatar Nov 06 '24 21:11 bhack

Hi @bhack I believe that is correct. Generation of the .so requires a devel image. That was my observation too when I tried it few months ago.

agunapal avatar Nov 07 '24 19:11 agunapal

Is this what we want? If yes do we want to document it?

bhack avatar Nov 07 '24 20:11 bhack

Will update the tutorial once https://github.com/pytorch/pytorch/issues/140055 and https://github.com/pytorch/pytorch/issues/140053 are resolved. This likely already works in the nightlies

agunapal avatar Nov 07 '24 22:11 agunapal

Any update?

bhack avatar Dec 03 '24 13:12 bhack

@bhack i will update the tutorial for PT 2.6

agunapal avatar Dec 03 '24 15:12 agunapal

@agunapal I am adding g++ in runtime images with https://github.com/pytorch/pytorch/pull/138612 to solve https://github.com/pytorch/pytorch/issues/116696 (torch.compile) but I suppose that it is not enough for you export. What do you think?

bhack avatar Dec 03 '24 15:12 bhack

Yes, I will mention in the updated tutorial that you need a devel image to create .pt2 package

agunapal avatar Dec 03 '24 15:12 agunapal