tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

Update outdated docs for torch logs

Open nluu175 opened this issue 1 year ago • 8 comments

Fixes #137285

Description

Update Python code to better address the usage of python logging and torch.compile.

Checklist

  • [x] The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • [x] Only one issue is addressed in this pull request
  • [x] Labels from the issue that this PR is fixing are added to this pull request
  • [x] No unnecessary issues are included into this pull request.

cc @williamwen42 @msaroufim @anijain2305

nluu175 avatar Oct 30 '24 03:10 nluu175

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3127

Note: Links to docs will display an error until the docs builds have been completed.

:x: 1 New Failure

As of commit b7b69041d5df4c686cc914ed4791ff0ff79ff0ca with merge base f7d06b68cbaa2e8aa59278064d40921b939d8a7a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Oct 30 '24 03:10 pytorch-bot[bot]

@ezyang could you please give me some feedbacks on this fix?

nluu175 avatar Oct 30 '24 03:10 nluu175

@pytorchbot label "torch.compile"

nluu175 avatar Oct 30 '24 03:10 nluu175

Didn't find following labels among repository labels: module: logging

pytorch-bot[bot] avatar Oct 30 '24 03:10 pytorch-bot[bot]

TBH, maybe we should introduce tlparse here, it's much better for looking at the output code bits. Description at https://docs.google.com/document/d/1y5CRfMLdwEoF1nTk9q8qEu1mgMUuUtvhklPKJ2emLU8/edit?tab=t.0#heading=h.u9711c2s6w0c

ezyang avatar Oct 31 '24 02:10 ezyang

TBH, maybe we should introduce tlparse here, it's much better for looking at the output code bits. Description at https://docs.google.com/document/d/1y5CRfMLdwEoF1nTk9q8qEu1mgMUuUtvhklPKJ2emLU8/edit?tab=t.0#heading=h.u9711c2s6w0c

Thank you! I'll take a look at it.

nluu175 avatar Oct 31 '24 02:10 nluu175

waiting for render

ezyang avatar Nov 07 '24 16:11 ezyang

@ezyang hello. Do I need to make any more modifications for this issue? I see that the pipeline is still waiting to be reported.

nluu175 avatar Nov 14 '24 03:11 nluu175

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as stale.
Feel free to remove the stale label if you feel this was a mistake.
If you are unable to remove the stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Mar 30 '25 00:03 github-actions[bot]