tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

Tutorials : Pretraining VGG from Scrtach

Open woongjoonchoi opened this issue 1 year ago • 15 comments

Fixes #ISSUE_NUMBER

Description

I make a new tutorial training VGG from scratch . There are no tutorials traning Vgg from scratch.

Checklist

  • [ ] The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • [ ] Only one issue is addressed in this pull request
  • [ ] Labels from the issue that this PR is fixing are added to this pull request
  • [ ] No unnecessary issues are included into this pull request.

cc @subramen @albanD @jbschlosser

woongjoonchoi avatar Jul 13 '24 10:07 woongjoonchoi

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2971

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit 264543e587841653e379d12058dd60e646be7dee with merge base dfeb1aebb3151e8dc04a4be2fbcc941355891012 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jul 13 '24 10:07 pytorch-bot[bot]

Hi @svekars, could you please help to take a look of this PR?

woongjoonchoi avatar Jul 22 '24 07:07 woongjoonchoi

Hi @svekars, could you please help to take a look of this PR again? I fix pyspellchecker issue and package install issue.

woongjoonchoi avatar Jul 24 '24 05:07 woongjoonchoi

Hi @svekars , could you please help to take a look of this PR again?

woongjoonchoi avatar Aug 12 '24 02:08 woongjoonchoi

@woongjoonchoi we are still waiting on @jbschlosser to take a look - stay tuned.

svekars avatar Aug 20 '24 16:08 svekars

@svekars are you okay with handling review for the polish needed for this tutorial? (e.g. grammar / punctuation / spacing). I added several comments regarding this but it's incomplete and I shifted to focusing on the ML component of the tutorial.

@jbschlosser yes, I will do the editorial pass as long as we align on the overall technical content.

svekars avatar Aug 29 '24 16:08 svekars

@svekars Sorry for being late. I've been busy with lab work. I've made some revisions based on the feedback I received. Could you check again?

woongjoonchoi avatar Sep 16 '24 05:09 woongjoonchoi

There is a build error related to the code.

svekars avatar Sep 16 '24 16:09 svekars

@svekars Are there any other things I need to fix?

woongjoonchoi avatar Oct 04 '24 01:10 woongjoonchoi

This tutorial takes almost 200 minutes to build: https://docs-preview.pytorch.org/pytorch/tutorials/2971/beginner/Pretraining_Vgg_from_scratch.html which we can't support. I suggest you convert this to .rst instead so that it does not run in our CI.

svekars avatar Oct 08 '24 15:10 svekars

@svekars Hi. svekars

I changed .html to .rst file and added it to begginer_source as .rst instead of .py. Sorry for the delay.

woongjoonchoi avatar Nov 16 '24 07:11 woongjoonchoi

Hi @svekars . I have converted it to an rst file, but is there anything else that needs to be refined?

woongjoonchoi avatar Dec 02 '24 04:12 woongjoonchoi

Hi @svekars .
I've taken your suggestion and modified it.

woongjoonchoi avatar Dec 09 '24 01:12 woongjoonchoi

@woongjoonchoi - there are still a lot of things to fix in the .rst - it's is 3K line long right now - it should be way shorter. There are many empty lines, You also don't need that whole training log.

svekars avatar Dec 13 '24 16:12 svekars

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as stale.
Feel free to remove the stale label if you feel this was a mistake.
If you are unable to remove the stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Mar 04 '25 00:03 github-actions[bot]