tutorials
tutorials copied to clipboard
Updated linalg functions in tensors_deeper_tutorial.py
Fixes #2933
Description
Hi, after reading #2933, there are a few things that I noted while attempting to solve this issue:
- While
torch.crossis more flexible and allows you for more complex cross products, I believe the expected behavior is usually the one fromtorch.linalg.crossimplementation. In this discussion it explains why blindly usingtorch.crosscan lead you to an intersting bug-hunting. - The function
torch.svdis deprecated and will be removed in future pytorch release. - For completion and to avoid beginner user confusion, I also changed to use
torch.linalg.matmulwhich actually callstorch.matmul, but I think it would be better from a beginner user standpoint, to refer them totorch.linalgfor all linear algebra related operations. - It would be nice to add maybe a tag/flag in the youtube video here mentioning the updates to linear algebra operations.
- Added ref to
torch.linalgdocs.
Checklist
- [x] The issue that is being fixed is referred in the description
- [x] Only one issue is addressed in this pull request
- [ ] Labels from the issue that this PR is fixing are added to this pull request
- [x] No unnecessary issues are included into this pull request.
cc @albanD
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2959
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:white_check_mark: No Failures
As of commit 80501207d21a4acea1c3a70626c755b5017e66a4 with merge base 740e3b01fc928b8fdb13762a8c52c844fbd0f792 ():
:green_heart: Looks good so far! There are no failures yet. :green_heart:
This comment was automatically generated by Dr. CI and updates every 15 minutes.