torchx icon indicating copy to clipboard operation
torchx copied to clipboard

update kfp and lightning dependencies

Open d4l3k opened this issue 3 years ago • 3 comments

This bumps the kfp and lightning versions. The previous diff only bumped lightning but had a dependency incompatibility for typing-extensions. https://github.com/pytorch/torchx/pull/574

Test plan:

CI

d4l3k avatar Aug 05 '22 18:08 d4l3k

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 05 '22 18:08 facebook-github-bot

Codecov Report

Merging #577 (d005ff3) into main (515a265) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          67       67           
  Lines        4047     4047           
=======================================
  Hits         3835     3835           
  Misses        212      212           

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Aug 05 '22 18:08 codecov[bot]

Hi @d4l3k!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 21 '23 08:01 facebook-github-bot