torchx icon indicating copy to clipboard operation
torchx copied to clipboard

feat: add metadata parameters to dist/spmd components (#1037)

Open clumsy opened this issue 8 months ago • 2 comments

See #1037 1037

Test plan: [x] updated unit tests

clumsy avatar Mar 28 '25 23:03 clumsy

@kiukchung has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 01 '25 19:05 facebook-github-bot

Is there anything else left to do for this PR to get merged, @kiukchung ? Thanks!

clumsy avatar May 13 '25 16:05 clumsy

Hi @kiukchung is there something I can do to help merge this one? Thanks!

clumsy avatar Oct 03 '25 19:10 clumsy

Hi @kiukchung is there something I can do to help merge this one? Thanks!

yep. Can you try rebasing?

kiukchung avatar Oct 06 '25 17:10 kiukchung

Done, @kiukchung. I don't see any issues locally.

clumsy avatar Oct 06 '25 18:10 clumsy

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 91.63%. Comparing base (1e3df20) to head (1429367).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   91.60%   91.63%   +0.03%     
==========================================
  Files          83       83              
  Lines        6431     6431              
==========================================
+ Hits         5891     5893       +2     
+ Misses        540      538       -2     
Flag Coverage Δ
unittests 91.63% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Oct 06 '25 18:10 codecov-commenter