torchtune icon indicating copy to clipboard operation
torchtune copied to clipboard

Qwen 2.5 VL

Open albert-inflection opened this issue 5 months ago • 2 comments

Context

What is the purpose of this PR? Is it to

  • [X] add a new feature
  • [ ] fix a bug
  • [ ] update tests and/or documentation
  • [ ] other (please add here)

Please link to any issues this PR addresses. https://github.com/pytorch/torchtune/issues/2699

Changelog

What are the changes made in this PR? *custom modules for Qwen 2.5 VL *model + component builders for all variants *Transform + custom collation *Weight loading *Added unit tests

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

so far we've done

  • Logit comparison against HF for encoder, decoder, and combined models (combined shown) Screenshot 2025-07-03 at 4 00 26 PM

  • successful E2E training runs for all model variants (7B run shown) Screenshot 2025-07-02 at 5 53 53 PM

  • [ ] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • [X] add unit tests for any new functionality
  • [ ] update docstrings for any new or updated methods or classes
  • [ ] run unit tests via pytest tests
  • [ ] run recipe tests via pytest tests -m integration_test
  • [X] manually run any new or modified recipes with sufficient proof of correctness
  • [X] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it. Here is a docstring example and a tutorial example

  • [X] I did not change any public API
  • [ ] I have added an example to docs or docstrings

co-authored by @lawrencefeng17

albert-inflection avatar Jul 03 '25 23:07 albert-inflection

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2868

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jul 03 '25 23:07 pytorch-bot[bot]

a bit rocky, early looks appreciated @joecummings

albert-inflection avatar Jul 03 '25 23:07 albert-inflection