torchtune icon indicating copy to clipboard operation
torchtune copied to clipboard

Assert LLama Vision Image size divides by 14

Open pbontrager opened this issue 1 year ago • 3 comments
trafficstars

Image size must be divisible by ViT patches in the CLIP encoder, 14.

pbontrager avatar Oct 02 '24 21:10 pbontrager

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1745

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 2ac9100db09be9d37f6616a18d4fd89ab44eb0e0 with merge base 7cf656be530dfebbcc785d57d20543b3344e3352 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Oct 02 '24 21:10 pytorch-bot[bot]

Add a test.

joecummings avatar Oct 02 '24 21:10 joecummings

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (7cf656b) to head (2ac9100). Report is 444 commits behind head on main.

Files with missing lines Patch % Lines
...orchtune/models/llama3_2_vision/_model_builders.py 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
+ Coverage   69.33%   69.34%   +0.01%     
==========================================
  Files         305      305              
  Lines       15892    15914      +22     
==========================================
+ Hits        11018    11036      +18     
- Misses       4874     4878       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Oct 02 '24 21:10 codecov-commenter