torchsnapshot
torchsnapshot copied to clipboard
Add fsspec storage plugin
Fixes #102
Codecov Report
Merging #114 (32358df) into main (7fd1ece) will decrease coverage by
6.10%. The diff coverage is26.78%.
:exclamation: Current head 32358df differs from pull request most recent head f282366. Consider uploading reports for the commit f282366 to get more accurate results
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 91.82% 85.71% -6.11%
==========================================
Files 31 32 +1
Lines 2557 2612 +55
==========================================
- Hits 2348 2239 -109
- Misses 209 373 +164
| Impacted Files | Coverage Δ | |
|---|---|---|
| torchsnapshot/storage_plugins/gcs.py | 0.00% <ø> (-78.90%) |
:arrow_down: |
| torchsnapshot/storage_plugin.py | 44.73% <25.00%> (-23.84%) |
:arrow_down: |
| torchsnapshot/storage_plugins/fsspec.py | 26.92% <26.92%> (ø) |
|
| torchsnapshot/storage_plugins/s3.py | 26.82% <0.00%> (-63.42%) |
:arrow_down: |
| torchsnapshot/memoryview_stream.py | 63.33% <0.00%> (-6.67%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Hi @shicheng0829!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Fix some bugs and add more unit test. Please review the pr again if you have free time. Thank you!