torchrec icon indicating copy to clipboard operation
torchrec copied to clipboard

OSS TorchRec Internal MPZCH modules (#3017)

Open lizhouyu opened this issue 5 months ago • 2 comments

Summary:

Major changes

  • Copy the following files from fb to corresponding location in the torchrec repository
    • fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py
    • fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py
    • fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py
    • fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py
    • fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py
    • fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py
  • Create a test_hash_zch_mc.py file in torchrec/distributed/tests folder following the test_quant_mc_embedding.py in torchrec/fb/distributed/tests.
    • trimmed quantization and inference codes, and only kept the training part.
    • rewire the related packages from torchrec.fb to torchrec
  • Update BUCK files in related folders
  • Update the affected repos to use torchrec modules instead of the modules in torchrec.fb
  • Update /modules/hash_mc_metrics.py
    • Replace the tensorboard module with a local file logger in hash_mc_metrics.py module
  • Update the license declaration headers for the four OSS files

ToDos after landing this Diff

  • Clean the duplicated hash_mc_modules.py file in the fb folder for safe landing.

Differential Revision: D76476676

lizhouyu avatar Jun 12 '25 22:06 lizhouyu

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 12 '25 22:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 12 '25 22:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 27 '25 17:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 27 '25 17:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 27 '25 18:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 27 '25 18:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 27 '25 18:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 27 '25 18:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 27 '25 19:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76476676

facebook-github-bot avatar Jun 27 '25 19:06 facebook-github-bot

This pull request has been reverted by 3ef5b3797e00f7b0e2dda8028c02b26b5a0978b8.

facebook-github-bot avatar Jun 29 '25 08:06 facebook-github-bot