torchrec icon indicating copy to clipboard operation
torchrec copied to clipboard

Update comment in VectorCrossNet in crossnet.py to correctly reflect …

Open PrashanthCorp opened this issue 8 months ago • 1 comments

…the code and spec in DCN V1 paper

The original comment mentioned the bias was scaled by x_0. The paper mentions the bias is a separate term in the update

https://arxiv.org/abs/1708.05123

Section 2.2. Mentions the update eqn in the cross Network

X_{l+1} = x_0 x_l^T w_l + b_l + x_l

PrashanthCorp avatar Apr 01 '25 22:04 PrashanthCorp

Hi @PrashanthCorp!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Apr 01 '25 22:04 facebook-github-bot