torchrec icon indicating copy to clipboard operation
torchrec copied to clipboard

Adjust default options for HeteroEmbeddingShardingPlanner

Open gnahzg opened this issue 1 year ago • 3 comments

Summary: (1) Let HeteroEmbeddingShardingPlanner use MemoryBalancedPartitioner instead of GreedyPerfPartitioner. Using MemoryBalancedPartitioner makes more sense due to the nature of diffrerent DDR/HBM sizes (2) Let HeteroEmbeddingShardingPlanner use EmbeddingEnumerator with exact emumerate order. This would allow to have the exact order which may be useful in the model publishing side

Differential Revision: D56305107

gnahzg avatar Apr 18 '24 15:04 gnahzg

This pull request was exported from Phabricator. Differential Revision: D56305107

facebook-github-bot avatar Apr 18 '24 15:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56305107

facebook-github-bot avatar Apr 18 '24 16:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56305107

facebook-github-bot avatar Apr 18 '24 17:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56305107

facebook-github-bot avatar May 07 '24 17:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56305107

facebook-github-bot avatar May 07 '24 19:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56305107

facebook-github-bot avatar May 08 '24 00:05 facebook-github-bot