torchrec
torchrec copied to clipboard
gpu version `int_nbit_split_embedding_codegen_lookup_function` not support `indices` and `offsets` with uint64 dtype
This PR removes uint32 indices protection in quant/embedding_modules.py. Nevertheless, when indices and offsets inputs of uint64 dtype are provided, int_nbit_split_embedding_codegen_lookup_function triggers a RuntimeError: expected scalar type Int but found Long on the GPU. Would it be possible to add support for the uint64 dtype on GPU devices?
It what cases would it be necessary to use uint64?
It what cases would it be necessary to use uint64?
In certain scenarios, the uint32 data type is insufficient to contain the indices for user_id and several combo feature.
@tiankongdeguiji Hi, let me bring this to the FBGEMM team's attention and get back to you.