torchrec icon indicating copy to clipboard operation
torchrec copied to clipboard

Make sure unweighted emb lookup executes before fp emb lookup

Open zhouxie000 opened this issue 1 year ago • 2 comments

Summary: Sort group keys in embedding_sharding so keys(lookups) with has_feature_processor=True executes first.

Differential Revision: D55045404

zhouxie000 avatar Mar 19 '24 00:03 zhouxie000

This pull request was exported from Phabricator. Differential Revision: D55045404

facebook-github-bot avatar Mar 19 '24 00:03 facebook-github-bot

Hi @zhouxie000!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jun 15 '24 01:06 facebook-github-bot