torchrec icon indicating copy to clipboard operation
torchrec copied to clipboard

Small syntactic changes for dynamo compatibility

Open IvanKobzarev opened this issue 1 year ago • 3 comments

Summary: Dynamo has some gaps in support of generators, list comprehension etc. Avoiding them for now with syntactic changes

Previous diff was reverted because recat was created on the target device from the start. Then with per-item manipulations it was writing directly to device (which broke freya training as it looks like freya does not support per-item changes).

In this diff recat is created on "cpu", the same as List[int] in original version.

Differential Revision: D54192498

IvanKobzarev avatar Feb 26 '24 12:02 IvanKobzarev

This pull request was exported from Phabricator. Differential Revision: D54192498

facebook-github-bot avatar Feb 26 '24 12:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54192498

facebook-github-bot avatar Feb 27 '24 17:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54192498

facebook-github-bot avatar Feb 27 '24 17:02 facebook-github-bot