torchchat icon indicating copy to clipboard operation
torchchat copied to clipboard

deps: Add set -x for installation commands

Open seemethere opened this issue 1 year ago • 1 comments

Adds set -x for all installation commands in install_requirements.sh so that users can see what's actually being installed and can help debug when they run into any issues.

NOTE: This doesn't turn it on for all of the script (since that'd be overbearing) but rather turns it on specifically when installing things.

This also adds "set -eou pipefail" to the top of the script which is a recommended paradigm for all bash scripts since it adds things like error on exit, error on undefined variable, and propagation of errors on pipe failure.

https://explainshell.com/explain?cmd=set+-euo+pipefail

seemethere avatar Aug 01 '24 18:08 seemethere

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/993

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit f6a0049444f0866d47ff68a8d6fe34cc5c48d904 with merge base 35db0389ae20be1247bd5ce936e479a76d947c7d (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Aug 01 '24 18:08 pytorch-bot[bot]