torcharrow icon indicating copy to clipboard operation
torcharrow copied to clipboard

Default aggregation functions delegates to Arrow Compute

Open wenleix opened this issue 4 years ago • 1 comments
trafficstars

IColumn.sum/mean/std/median/quantile/mode/all/any: https://github.com/facebookresearch/torcharrow/blob/380e1cbaf334b49d52242596c79627d456ef3b0d/torcharrow/icolumn.py#L1206-L1292

Also remove the Python implementation in cpu backend (if there is). Since once zero-copy interop with Arrow is implemented, it's more efficient to use Arrow Compute. Eventually we probably want to directly use the aggregation implementation in Velox.

Example delegation of min/max: https://github.com/facebookresearch/torcharrow/pull/52

wenleix avatar Nov 05 '21 18:11 wenleix

cc @damianr99 , @pedroerp , @OswinC

wenleix avatar Nov 05 '21 18:11 wenleix