tensorpipe icon indicating copy to clipboard operation
tensorpipe copied to clipboard

Close file descriptors after mapping ring buffer

Open pietern opened this issue 5 years ago • 1 comments
trafficstars

No need to keep them open once the memory has been mapped.

Also, we keep them as int on the shm connection, so they aren't cleaned up on destruction.

pietern avatar Feb 10 '20 09:02 pietern

Note: They should be cleaned up as part of ~Segment() in tensorpipe/util/shm/segment.cc.

beauby avatar Mar 03 '20 13:03 beauby