serve icon indicating copy to clipboard operation
serve copied to clipboard

fix: volume permission in kubernetes setup

Open jagadeeshi2i opened this issue 3 years ago • 2 comments

Signed-off-by: jagadeesh [email protected]

Description

Fixes security context issue while installing TS helm chart. The model-server user own the /home/model-server path where the volume is being mounted.

Fixes #1337 TS install output: screenshot

TS pod describe output: image

test.log

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [] This change requires a documentation update

Checklist:

  • [x] Did you have fun?
  • [x] Have you added tests that prove your fix is effective or that this feature works?
  • [ ] Has code been commented, particularly in hard-to-understand areas?
  • [ ] Have you made corresponding changes to the documentation?

jagadeeshi2i avatar Jul 20 '22 09:07 jagadeeshi2i

Codecov Report

Merging #1747 (1fa9371) into master (6b4dc84) will increase coverage by 3.28%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
+ Coverage   41.67%   44.95%   +3.28%     
==========================================
  Files          55       63       +8     
  Lines        2282     2609     +327     
  Branches        1       56      +55     
==========================================
+ Hits          951     1173     +222     
- Misses       1331     1436     +105     
Impacted Files Coverage Δ
...hiver/workflow_archiver/workflow_archiver_error.py 100.00% <0.00%> (ø)
...iver/workflow_archiver/workflow_packaging_utils.py 68.68% <0.00%> (ø)
...l-archiver/model_archiver/model_packaging_utils.py 54.96% <0.00%> (ø)
...el-archiver/model_archiver/model_archiver_error.py 100.00% <0.00%> (ø)
...w-archiver/workflow_archiver/workflow_packaging.py 89.65% <0.00%> (ø)
model-archiver/model_archiver/version.py 100.00% <0.00%> (ø)
workflow-archiver/workflow_archiver/version.py 100.00% <0.00%> (ø)
model-archiver/model_archiver/model_packaging.py 90.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 25 '22 18:07 codecov[bot]

Hi @agunapal the securityContext fix is not required for native torchserve. As TS mount the PV in /home/model-server path which is owned by model-server. The fix was earlier added for other integration like kserve.

jagadeeshi2i avatar Jul 26 '22 08:07 jagadeeshi2i