pytorch_sphinx_theme icon indicating copy to clipboard operation
pytorch_sphinx_theme copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

remove deprecated `style` variable

Open ain-soph opened this issue 2 years ago • 2 comments

style variable is deprecated in sphinx 7.0.0. However, in current pytorch_sphinx_theme, we are still using it.

https://github.com/pytorch/pytorch_sphinx_theme/blob/a1dbd5cfa0a69ee023d0c0acc167fb0cbd8619f6/pytorch_sphinx_theme/layout.html#L43-L45

Following is the solution from sphinx-rtd-theme:
https://github.com/readthedocs/sphinx_rtd_theme/blob/03a86b803cf7cf281748ef94345ba7c35953952a/sphinx_rtd_theme/layout.html#L26-L30

They add an if condition for compatibility with very old sphinx<4.0. I think we can just remove those codes.

https://www.sphinx-doc.org/en/master/changes.html

image

ain-soph avatar May 14 '23 21:05 ain-soph

Sorry for the late response. I know this is a valid issue. Did you have a chance to test this against Sphinx version 5.0 and older? A lot of pytorch sites still use the older version.

svekars avatar Dec 05 '23 22:12 svekars

@svekars Sorry that I don't have time to test it recently. If it's not in a hurry, I may test that during Christmas.

ain-soph avatar Dec 07 '23 04:12 ain-soph