pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[MPS] Add support for autocast in MPS

Open kulinseth opened this issue 2 years ago • 28 comments

Fixes https://github.com/pytorch/pytorch/issues/88415

cc @mcarilli @ptrblck @leslie-fang-intel @jgong5

kulinseth avatar Apr 16 '23 19:04 kulinseth

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/99272

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit c5aec3133d70d1a5d50fd33f99adc1c18ca1676c with merge base 71383dd3dae22b00161a9acb4f351e25b7e54ee8 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 16 '23 19:04 pytorch-bot[bot]

@kulinseth It seems there is still some work to be done, here. What's your plan to address some of these comments?

johnrichardrinehart avatar Jun 08 '23 11:06 johnrichardrinehart

Any update on this @kulinseth ?

albanD avatar Jun 22 '23 02:06 albanD

Any update on this @kulinseth ?

Yes, I need to rebase and update here. I will do it this week.

kulinseth avatar Jun 23 '23 01:06 kulinseth

@kulinseth Still in progress? Looks so based on #104191 .

johnrichardrinehart avatar Jun 29 '23 13:06 johnrichardrinehart

@kulinseth Is there any update on this please? This change would fix so many issues. Thank you

djollieb avatar Aug 10 '23 12:08 djollieb

@kulinseth Is there any update on this please? This change would fix so many issues. Thank you

Yes , I will cleanup and rebase again . Will have something by early next week to try

kulinseth avatar Aug 10 '23 14:08 kulinseth

@kulinseth Is there any update on this please? This change would fix so many issues. Thank you

Yes , I will cleanup and rebase again . Will have something by early next week to try

Any updates @kulinseth ?

johnrichardrinehart avatar Aug 19 '23 18:08 johnrichardrinehart

@kulinseth I'll buy you a coffee!

diffractometer avatar Sep 04 '23 15:09 diffractometer

Any updates @kulinseth ?

john1089 avatar Sep 09 '23 03:09 john1089

@kulinseth Can we do something to help?

PhilippeFerreiraDeSousa avatar Sep 18 '23 04:09 PhilippeFerreiraDeSousa

@kulinseth any chance it will be this year?

larsrnielsen avatar Oct 22 '23 02:10 larsrnielsen

Any updates @kulinseth it'd be really great to see this PR merged and would greatly improve so many upstream projects!

fakerybakery avatar Nov 03 '23 01:11 fakerybakery

Any updates @kulinseth? Have been eagerly awaiting this merge, would be super useful for various projects!

Abdullah-R avatar Nov 30 '23 05:11 Abdullah-R

@kulinseth as you have stopped to work on it (according to your activity), is there someone else that can get it done?

larsrnielsen avatar Dec 02 '23 20:12 larsrnielsen

@kulinseth as you have stopped to work on it (according to your activity), is there someone else that can get it done?

I am enlisting help from others (cc @malfet ) on this if we I can’t get to it in next 2 weeks .

kulinseth avatar Dec 06 '23 15:12 kulinseth

@kulinseth just wanted to follow up on the progress of this.

Appreciate the work you're doing :)

rajdtta avatar Dec 28 '23 15:12 rajdtta

So when this pr will be merged?

john1089 avatar Jan 06 '24 06:01 john1089

@kulinseth as you have stopped to work on it (according to your activity), is there someone else that can get it done?

I am enlisting help from others (cc @malfet ) on this if we I can’t get to it in next 2 weeks .

any updates?

larsrnielsen avatar Jan 29 '24 23:01 larsrnielsen

any updates on this?

piotrpersona avatar Feb 22 '24 22:02 piotrpersona

When do you think this pr could be merged?

helsenIgnace avatar Mar 01 '24 15:03 helsenIgnace

Is progress being made or has this PR been abandoned?

Abdullah-R avatar Mar 02 '24 04:03 Abdullah-R

An update pls? 🙂

petros94 avatar Mar 14 '24 23:03 petros94

also pinging for updates, would love to see this

galenmarchetti avatar Mar 18 '24 01:03 galenmarchetti

Will this PR merged one day ? Need help ?

bastienjalbert avatar Mar 21 '24 16:03 bastienjalbert

@albanD please re-review

bghira avatar Mar 23 '24 13:03 bghira

@kulinseth a gentle ping since pytorch 2.3 has bf16 on mps now

bghira avatar Apr 02 '24 13:04 bghira

@kulinseth I am interested in trying out AMP on my M3 Pro. Are there any updates regarding this PR?

arodri48 avatar May 18 '24 01:05 arodri48

hi, @kulinseth I rebase your patch on latest main branch, could you help to review it ?

Thanks

janboeye avatar May 21 '24 12:05 janboeye

@pytorchbot rebase

skotapati avatar Jun 28 '24 00:06 skotapati