pytorch enable channels last 3d for Conv3d and ConvTranspose3d on mkldnn path

Stack from ghstack:

-> #74023
#70897
#77060

Differential Revision: D35782442

Add channels last 3d support for both Conv3d and ConvTransposed3d

Mar 10 '22 07:03 mingfeima

CI Flow Status

:atom_symbol: CI Flow

Ruleset - Version: v1 Ruleset - File: https://github.com/pytorch/pytorch/blob/031a67b2ae6c70fdccfd6e8c28659af24aae99de/.github/generated-ciflow-ruleset.json PR ciflow labels: ciflow/default Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	:white_check_mark: triggered
linux-binary-libtorch-cxx11-abi	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	:white_check_mark: triggered
linux-binary-libtorch-pre-cxx11	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	:white_check_mark: triggered
linux-binary-manywheel	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`, `ciflow/trunk`	:white_check_mark: triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	:white_check_mark: triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	:white_check_mark: triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	:white_check_mark: triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	:white_check_mark: triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	:white_check_mark: triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	:white_check_mark: triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	:white_check_mark: triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	:white_check_mark: triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	:white_check_mark: triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	:white_check_mark: triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	:white_check_mark: triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	:white_check_mark: triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	:white_check_mark: triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	:white_check_mark: triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	:white_check_mark: triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	:white_check_mark: triggered
windows-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	:white_check_mark: triggered
windows-binary-libtorch-debug	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	:white_check_mark: triggered
windows-binary-libtorch-release	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	:white_check_mark: triggered
windows-binary-wheel	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`, `ciflow/trunk`	:white_check_mark: triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	:no_entry_sign: skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	:no_entry_sign: skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	:no_entry_sign: skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	:no_entry_sign: skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	:no_entry_sign: skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	:no_entry_sign: skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	:no_entry_sign: skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	:no_entry_sign: skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	:no_entry_sign: skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	:no_entry_sign: skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	:no_entry_sign: skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	:no_entry_sign: skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	:no_entry_sign: skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	:no_entry_sign: skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	:no_entry_sign: skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	:no_entry_sign: skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	:no_entry_sign: skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	:no_entry_sign: skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	:no_entry_sign: skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	:no_entry_sign: skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	:no_entry_sign: skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	:no_entry_sign: skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	:no_entry_sign: skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	:no_entry_sign: skipped

Mar 10 '22 07:03 pytorch-bot[bot]

:link: Helpful links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/74023
:page_facing_up: Preview Python docs built from this PR
:page_facing_up: Preview C++ docs built from this PR
:question:Need help or want to give feedback on the CI? Visit our office hours

:x: 1 New Failures

As of commit 5e1a632859 (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

:detective: 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/1)

Step: "Build" (full log | diagnosis details | :repeat: rerun)

2022-07-27T07:46:17.8077904Z [0m[1m[31mERROR...ch file or directory\ncompilation terminated.\n" }

2022-07-27T07:46:17.7148529Z [31m[1mFAILED:[0m Build did NOT complete successfully
2022-07-27T07:46:17.7207011Z [31m[1mFAILED:[0m Build did NOT complete successfully
2022-07-27T07:46:17.7348233Z [0m+ sccache_epilogue
2022-07-27T07:46:17.7348875Z + echo '::group::Sccache Compilation Log'
2022-07-27T07:46:17.7349952Z ##[group]Sccache Compilation Log
2022-07-27T07:46:17.7350447Z + echo '=================== sccache compilation log ==================='
2022-07-27T07:46:17.7350884Z =================== sccache compilation log ===================
2022-07-27T07:46:17.7351469Z + python /var/lib/jenkins/workspace/.jenkins/pytorch/print_sccache_log.py /var/lib/jenkins/sccache_error.log
2022-07-27T07:46:17.8074953Z [0m[1m[31mERROR[0m 2022-07-27T07:46:16Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "aten/src/ATen/native/NaiveConvolutionTranspose2d.cpp: In function \'void at::native::{anonymous}::slow_conv_transpose2d_acc_grad_parameters_cpu(const at::Tensor&, const at::Tensor&, const at::Tensor&, at::Tensor&, at::Tensor&, at::IntArrayRef, at::IntArrayRef, at::IntArrayRef, at::IntArrayRef, at::IntArrayRef, int)\':\naten/src/ATen/native/NaiveConvolutionTranspose2d.cpp:647:8: error: variable \'is_batch\' set but not used [-Werror=unused-but-set-variable]\n   bool is_batch = false;\n        ^~~~~~~~\ncc1plus: some warnings being treated as errors\n" }
2022-07-27T07:46:17.8076269Z 
2022-07-27T07:46:17.8077904Z [0m[1m[31mERROR[0m 2022-07-27T07:46:16Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "In file included from aten/src/ATen/TensorIndexing.h:12:0,\n                 from aten/src/ATen/ATen.h:18,\n                 from aten/src/ATen/native/RNN.h:3,\n                 from aten/src/ATen/native/RNN.cpp:1:\nbazel-out/k8-fastbuild/bin/aten/src/ATen/NativeFunctions.h:596:10: fatal error: bazel-out/k8-fastbuild/bin/aten/src/ATen/ops/_ctc_loss_backward_native.h: No such file or directory\ncompilation terminated.\n" }
2022-07-27T07:46:17.8078790Z 
2022-07-27T07:46:17.8101306Z + echo '=========== If your build fails, please take a look at the log above for possible reasons ==========='
2022-07-27T07:46:17.8101910Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2022-07-27T07:46:17.8102404Z + sccache --show-stats
2022-07-27T07:46:17.8124395Z Compile requests                   1876
2022-07-27T07:46:17.8124741Z Compile requests executed          1398
2022-07-27T07:46:17.8125203Z Cache hits                         1143
2022-07-27T07:46:17.8125851Z Cache hits (C/C++)                 1143
2022-07-27T07:46:17.8126131Z Cache misses                        242
2022-07-27T07:46:17.8126432Z Cache misses (C/C++)                242

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Mar 10 '22 07:03 facebook-github-bot

@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Apr 20 '22 16:04 VitalyFedyunin

@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Apr 28 '22 17:04 VitalyFedyunin

@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

May 13 '22 15:05 VitalyFedyunin

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

Oct 04 '22 01:10 facebook-github-bot

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: mingfeima / name: Ma Mingfei (031a67b2ae6c70fdccfd6e8c28659af24aae99de, 04ea012b0064def382395a1427e90a74dd8460b7, db99395b95bf20fcc4b9f09611a67f250c5c9ab9, 48b07f7d282351dd7fb5dcc7a94b5eca35cb0d3a, 6682c17db3d4a16a40433d14e48a85bb4360b0b3, ed28af3600d0d17bc91919738677195de9791446, d5b9c80c9cde010e7586884f1a54bef4bcad5d69, 1fc4ece8102b386c2d83d74b3c02f4417a037f2a, aef28aa19f6e46b8d8606ddcba15efa9322236b6, 1fe58d517d00d305591ecf36d697ed33e276a55d, 184d2975ebf294fe85e84ed6ffa5afcefd59e49a, d61a9f08537e610c5c5fb12117fe8300c5afd301, 8b24ad95d3a71118fda68cb0f7656f4f825bc9c2, 94ad744a6a737d09bf588a90ffcc89d357d3104a, 60bc1a173c5d4315afc05faf6445e0af8a37b996, 5e1a63285924260c4a989cfdba7de1d8c985a315)

Oct 04 '22 01:10 linux-foundation-easycla[bot]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Dec 19 '22 07:12 github-actions[bot]

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/74023

:page_facing_up: Preview Python docs built from this PR
:page_facing_up: Preview C++ docs built from this PR
:question: Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

:x: 5 Failures

As of commit 3f2a7b3b87cbeea8b9288479b0ff973cef8d2dc0:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Jan 18 '23 03:01 pytorch-bot[bot]