pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[BE] Make maybe_aliasing_or_mutating proper tag

Open tugsbayasgalan opened this issue 1 year ago • 13 comments

Stack from ghstack (oldest at bottom):

  • -> #131990

For better tracking, we need to make maybe aliasing/mutating ops with proper tag. We need to special case native_batch_norm because it is not a CIA but has a wrong schema. I guess native_batch_norm will be removed at some point, so until then we just keep it around.

Differential Revision: D60347117

tugsbayasgalan avatar Jul 28 '24 03:07 tugsbayasgalan

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/131990

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit bc3ffca22182c0692d47f11c0a0a77f1e20f64fb with merge base a84779040049377aec7b62e37becb7327950541e (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jul 28 '24 03:07 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D60347117

facebook-github-bot avatar Jul 28 '24 03:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60347117

facebook-github-bot avatar Aug 01 '24 08:08 facebook-github-bot

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Sep 30 '24 15:09 github-actions[bot]

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

tugsbayasgalan avatar Nov 19 '24 03:11 tugsbayasgalan

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

tugsbayasgalan avatar Nov 19 '24 03:11 tugsbayasgalan

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

tugsbayasgalan avatar Nov 19 '24 03:11 tugsbayasgalan

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

tugsbayasgalan avatar Nov 19 '24 13:11 tugsbayasgalan

looks like there are still some failing tests?

Yup i think most of them due to bad trunk tho

tugsbayasgalan avatar Nov 19 '24 18:11 tugsbayasgalan

@pytorchbot rebase

tugsbayasgalan avatar Nov 19 '24 18:11 tugsbayasgalan

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Nov 19 '24 18:11 pytorchmergebot

Successfully rebased gh/tugsbayasgalan/227/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/131990)

pytorchmergebot avatar Nov 19 '24 18:11 pytorchmergebot

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

tugsbayasgalan avatar Nov 20 '24 05:11 tugsbayasgalan

@pytorchbot rebase

tugsbayasgalan avatar Nov 20 '24 16:11 tugsbayasgalan

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Nov 20 '24 16:11 pytorchmergebot

Successfully rebased gh/tugsbayasgalan/227/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/131990)

pytorchmergebot avatar Nov 20 '24 16:11 pytorchmergebot

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

tugsbayasgalan avatar Nov 21 '24 20:11 tugsbayasgalan

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

facebook-github-bot avatar Nov 22 '24 19:11 facebook-github-bot

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Nov 22 '24 19:11 pytorchmergebot

@pytorchbot merge

izaitsevfb avatar Nov 23 '24 20:11 izaitsevfb

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Nov 23 '24 21:11 pytorchmergebot

@pytorchbot merge

izaitsevfb avatar Nov 23 '24 21:11 izaitsevfb

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Nov 23 '24 21:11 pytorchmergebot

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Nov 23 '24 21:11 pytorchmergebot

@pytorchbot merge -i

izaitsevfb avatar Nov 24 '24 00:11 izaitsevfb

Merge started

Your change will be merged while ignoring the following 1 checks: Meta Internal-Only Changes Check

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Nov 24 '24 00:11 pytorchmergebot