pytorch
pytorch copied to clipboard
remove empty partition
In some rare scenarios, the partitioner will produce an empty partition. it's a waste of time to compile an empty graph.
cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/124920
- :page_facing_up: Preview Python docs built from this PR
- :page_facing_up: Preview C++ docs built from this PR
- :question: Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours
Note: Links to docs will display an error until the docs builds have been completed.
:white_check_mark: You can merge normally! (1 Unrelated Failure)
As of commit 3be2a0592b08e8798b7eb15fe3996107fa17859f with merge base 6c4f43f82675b5fcfe8cf3e5983d0c0f326408aa ():
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
- pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, linux.8xlarge.nvidia.gpu) (gh) (trunk failure)
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! KeyboardInterrupt !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
This comment was automatically generated by Dr. CI and updates every 15 minutes.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: Ma-Jian1 / name: Ma Jian (3be2a0592b08e8798b7eb15fe3996107fa17859f)
@pytorchbot merge
Merge started
Your change will be merged once all checks pass (ETA 0-4 Hours).
Learn more about merging in the wiki.
Questions? Feedback? Please reach out to the PyTorch DevX TeamAdvanced Debugging
Check the merge workflow status
here
@pytorchbot revert -m "I think Dr CI is wrong, the xla failure looks real https://hud.pytorch.org/pytorch/pytorch/commit/98835fff9fd498472b0e8f49a3a4670d86f3c5b7 https://github.com/pytorch/pytorch/actions/runs/8840540357/job/24278180954" -c weird
@pytorchbot successfully started a revert job. Check the current status here. Questions? Feedback? Please reach out to the PyTorch DevX Team
@Ma-Jian1 your PR has been successfully reverted.
@clee2000 Sorry,seems the test case (xla/test/dynamo/test_dynamo.py)in not in the repo?I can't know why it's failed.
@pytorchbot rebase
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here
Rebase failed due to
Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged. Please rebase locally and push.
Raised by https://github.com/pytorch/pytorch/actions/runs/8850747978
@pytorchbot revert -m "I think Dr CI is wrong, the xla failure looks real https://hud.pytorch.org/pytorch/pytorch/commit/98835fff9fd498472b0e8f49a3a4670d86f3c5b7 https://github.com/pytorch/pytorch/actions/runs/8840540357/job/24278180954" -c weird
It's in the xla repo https://github.com/pytorch/xla/blob/4b481349d3b7f5487e8c68749415543de1a590a5/test/dynamo/test_dynamo.py#L632 cc @JackCaoG
Let me update the test, I will circle back when I have a pr
Let me merge https://github.com/pytorch/xla/pull/6981 and then we can update the XLA pin in this pr. @bdhirsh since we need to update XLA pin in this pr, maybe we can skip your other pr to update XLA PIN?
OK can we update hash in https://github.com/pytorch/pytorch/blob/main/.github/ci_commit_pins/xla.txt to b9a9449f205d10769660c428cc68755a6ffe183a
@pytorchbot rebase
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here
Rebase failed due to
Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged. Please rebase locally and push.
Raised by https://github.com/pytorch/pytorch/actions/runs/8900305245
@pytorchbot rebase -b main
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here
Rebase failed due to
Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged. Please rebase locally and push.
Raised by https://github.com/pytorch/pytorch/actions/runs/8900354709
@pytorchbot rebase -b main
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here
Rebase failed due to
Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged. Please rebase locally and push.
Raised by https://github.com/pytorch/pytorch/actions/runs/8977762410
OK can we update hash in https://github.com/pytorch/pytorch/blob/main/.github/ci_commit_pins/xla.txt to b9a9449f205d10769660c428cc68755a6ffe183a
@JackCaoG Any plan to merge it?
The pin have been updated on pytorch side, if you rebase it should start passing.
seems it has been merged and then reverted, I can't rebase it. what can I do to retrigger the test? @ezyang @JackCaoG @huydhn
You could always merge from main locally. Here is how I usually do it after syncing your fork repo: git checkout main && git pull origin main && git checkout YOUR_BRANCH && git merge main && git push
@pytorchbot merge
Merge started
Your change will be merged once all checks pass (ETA 0-4 Hours).
Learn more about merging in the wiki.
Questions? Feedback? Please reach out to the PyTorch DevX TeamAdvanced Debugging
Check the merge workflow status
here