pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

remove empty partition

Open majian4work opened this issue 1 year ago • 15 comments

In some rare scenarios, the partitioner will produce an empty partition. it's a waste of time to compile an empty graph.

cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen

majian4work avatar Apr 25 '24 08:04 majian4work

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/124920

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit 3be2a0592b08e8798b7eb15fe3996107fa17859f with merge base 6c4f43f82675b5fcfe8cf3e5983d0c0f326408aa (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 25 '24 08:04 pytorch-bot[bot]

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Ma-Jian1 / name: Ma Jian (3be2a0592b08e8798b7eb15fe3996107fa17859f)

@pytorchbot merge

ezyang avatar Apr 25 '24 19:04 ezyang

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Apr 25 '24 19:04 pytorchmergebot

@pytorchbot revert -m "I think Dr CI is wrong, the xla failure looks real https://hud.pytorch.org/pytorch/pytorch/commit/98835fff9fd498472b0e8f49a3a4670d86f3c5b7 https://github.com/pytorch/pytorch/actions/runs/8840540357/job/24278180954" -c weird

clee2000 avatar Apr 26 '24 02:04 clee2000

@pytorchbot successfully started a revert job. Check the current status here. Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot avatar Apr 26 '24 02:04 pytorchmergebot

@Ma-Jian1 your PR has been successfully reverted.

pytorchmergebot avatar Apr 26 '24 02:04 pytorchmergebot

@clee2000 Sorry,seems the test case (xla/test/dynamo/test_dynamo.py)in not in the repo?I can't know why it's failed.

majian4work avatar Apr 26 '24 03:04 majian4work

@pytorchbot rebase

ezyang avatar Apr 26 '24 15:04 ezyang

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Apr 26 '24 15:04 pytorchmergebot

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/8850747978

pytorchmergebot avatar Apr 26 '24 15:04 pytorchmergebot

@pytorchbot revert -m "I think Dr CI is wrong, the xla failure looks real https://hud.pytorch.org/pytorch/pytorch/commit/98835fff9fd498472b0e8f49a3a4670d86f3c5b7 https://github.com/pytorch/pytorch/actions/runs/8840540357/job/24278180954" -c weird

It's in the xla repo https://github.com/pytorch/xla/blob/4b481349d3b7f5487e8c68749415543de1a590a5/test/dynamo/test_dynamo.py#L632 cc @JackCaoG

clee2000 avatar Apr 26 '24 16:04 clee2000

Let me update the test, I will circle back when I have a pr

JackCaoG avatar Apr 26 '24 16:04 JackCaoG

Let me merge https://github.com/pytorch/xla/pull/6981 and then we can update the XLA pin in this pr. @bdhirsh since we need to update XLA pin in this pr, maybe we can skip your other pr to update XLA PIN?

JackCaoG avatar Apr 26 '24 17:04 JackCaoG

OK can we update hash in https://github.com/pytorch/pytorch/blob/main/.github/ci_commit_pins/xla.txt to b9a9449f205d10769660c428cc68755a6ffe183a

JackCaoG avatar Apr 26 '24 20:04 JackCaoG

@pytorchbot rebase

huydhn avatar Apr 30 '24 19:04 huydhn

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Apr 30 '24 19:04 pytorchmergebot

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/8900305245

pytorchmergebot avatar Apr 30 '24 19:04 pytorchmergebot

@pytorchbot rebase -b main

huydhn avatar Apr 30 '24 19:04 huydhn

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

pytorchmergebot avatar Apr 30 '24 19:04 pytorchmergebot

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/8900354709

pytorchmergebot avatar Apr 30 '24 19:04 pytorchmergebot

@pytorchbot rebase -b main

majian4work avatar May 07 '24 00:05 majian4work

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

pytorchmergebot avatar May 07 '24 00:05 pytorchmergebot

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/8977762410

pytorchmergebot avatar May 07 '24 00:05 pytorchmergebot

OK can we update hash in https://github.com/pytorch/pytorch/blob/main/.github/ci_commit_pins/xla.txt to b9a9449f205d10769660c428cc68755a6ffe183a

@JackCaoG Any plan to merge it?

majian4work avatar May 08 '24 01:05 majian4work

The pin have been updated on pytorch side, if you rebase it should start passing.

JackCaoG avatar May 08 '24 17:05 JackCaoG

seems it has been merged and then reverted, I can't rebase it. what can I do to retrigger the test? @ezyang @JackCaoG @huydhn

majian4work avatar May 09 '24 01:05 majian4work

You could always merge from main locally. Here is how I usually do it after syncing your fork repo: git checkout main && git pull origin main && git checkout YOUR_BRANCH && git merge main && git push

huydhn avatar May 09 '24 02:05 huydhn

@pytorchbot merge

ezyang avatar May 09 '24 04:05 ezyang

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar May 09 '24 04:05 pytorchmergebot