pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Setup initial testing harness and cache key generation for AOTAutograd Cache

Open jamesjwu opened this issue 1 year ago • 8 comments

Stack from ghstack (oldest at bottom):

  • #125157
  • #124745
  • -> #124642

This doesn't introduce any new behavior, but sets up a basic cache key generation mechanism that I can test. From here I will:

  • Add checks on the ops in an input FXGraph to make sure they are safe to cache. We'll be conservative in the first version here.
  • Add serialization for FX graphs
  • Save these FX graphs to disk in the cache
  • Support graphs with more complicated ops like higher order ops and specialized nn modules

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

jamesjwu avatar Apr 22 '24 19:04 jamesjwu

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/124642

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit d9e2a33fe826dcc7f037165930455936538dd0d6 with merge base 935a946241ce8f15686a0ad73a1b4c2b0f65f3f1 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 22 '24 19:04 pytorch-bot[bot]

@pytorchbot rebase

jamesjwu avatar Apr 29 '24 03:04 jamesjwu

Rebased gh/jamesjwu/17/orig onto refs/remotes/origin/viable/strict because #124745 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/124642)

pytorchmergebot avatar Apr 29 '24 03:04 pytorchmergebot

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Apr 29 '24 03:04 pytorchmergebot

Tried to rebase and push PR #124642, but it was already up to date. Try rebasing against main by issuing: @pytorchbot rebase -b main

pytorchmergebot avatar Apr 29 '24 03:04 pytorchmergebot

@pytorchmergebot rebase

jamesjwu avatar Apr 29 '24 23:04 jamesjwu

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Apr 29 '24 23:04 pytorchmergebot

Successfully rebased gh/jamesjwu/16/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/124642)

pytorchmergebot avatar Apr 29 '24 23:04 pytorchmergebot

@pytorchbot merge

jamesjwu avatar Apr 30 '24 15:04 jamesjwu

Merge failed

Reason: This PR needs a release notes: label If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Apr 30 '24 15:04 pytorchmergebot

@pytorchbot merge

jamesjwu avatar Apr 30 '24 15:04 jamesjwu

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Apr 30 '24 15:04 pytorchmergebot