pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Update CUTLASS-based sparse semi-structured GEMM

Open alexsamardzic opened this issue 1 year ago • 4 comments

Stack from ghstack (oldest at bottom):

  • -> #117124

cc @nikitaved @pearu @cpuhrsch @amjames @bhosmer @jcaip @ptrblck

alexsamardzic avatar Jan 10 '24 17:01 alexsamardzic

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/117124

Note: Links to docs will display an error until the docs builds have been completed.

:x: 1 New Failure, 2 Unrelated Failures

As of commit 8a1aa4b503fd9e2cec8b9419280f23b0d52b8be3 with merge base 2d4aa91a108218483761c12206a0debee69f4968 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jan 10 '24 17:01 pytorch-bot[bot]

This PR updates CUTLASS-bases sparse semi-structured GEMM implementation: it replaces use of SparseGemmRowBroadcast GEMM variation with using recently added EVT epilogue support for sparse GEMM - former was pretty much a hack, hopefully to be removed from CUTLASS, while EVT epilogues provide much more general approach to adding bias, applying activation functions and fusing other operations with sparse GEMM. PR is to be merged only after we upgrade CUTLASS pin in PyTorch either to commit adding EVT epilogues for sparse GEMM into CUTLASS, or a newer one.

alexsamardzic avatar Jan 10 '24 17:01 alexsamardzic

@alexsamardzic - We'll want to update to the next version of CUTLASS before we can pull this in. Do you know when the planned release is? Is the required change already part of a release?

cpuhrsch avatar Jan 18 '24 08:01 cpuhrsch

@alexsamardzic - We'll want to update to the next version of CUTLASS before we can pull this in. Do you know when the planned release is? Is the required change already part of a release?

The change is included in CUTLASS 3.4.0, released yesterday.

alexsamardzic avatar Jan 18 '24 10:01 alexsamardzic

Merged into main along with CUTLASS update to 3.4.1, through PR 120434.

alexsamardzic avatar Feb 23 '24 12:02 alexsamardzic