ignite icon indicating copy to clipboard operation
ignite copied to clipboard

Added The BInary Expected_Calibration_Error (ECE) Metric

Open Zekrom-7780 opened this issue 2 years ago • 5 comments

Fixes #1009

Description:

Added the binary ECE(Expected_Calibration_Error) metric.

Reviewers

cc. @vfdev-5

P.S.

  • Do I have to add new tests, and documentation for the new metric? I don't know whether I had to add them or not.
  • Will be doing the MultiClassECE in a new pull request, since it feels that it is the better thing to do.

Zekrom-7780 avatar Nov 11 '23 11:11 Zekrom-7780

Apply Sweep Rules to your PR?

  • [ ] Apply: All new business logic should have corresponding unit tests.
  • [ ] Apply: Refactor large functions to be more modular.

@vfdev-5 made the changes,

Ready for comments

Won't be possible to have a single class for binary and multi-class ECE ?

Will do it in the next commits if you want, actually I just wanted to understand how does the binaryclassECE work, and by completing that, the other one would be a piece of cake to do, hence just focusing on this one rn

Zekrom-7780 avatar Nov 13 '23 18:11 Zekrom-7780

@Zekrom-7780 any updates on this PR ?

vfdev-5 avatar Nov 22 '23 08:11 vfdev-5

@vfdev-5 I'll create the Multi-Class-ECE in the next 3-4 hours, and push the changes

Then i'll move to writing the unit-tests, where I'll need your help, since I haven't written any as such

Zekrom-7780 avatar Nov 22 '23 15:11 Zekrom-7780

@vfdev-5 , made the changes

Zekrom-7780 avatar Nov 22 '23 18:11 Zekrom-7780