functorch
functorch copied to clipboard
pytorch
functorch is JAX-like composable function transforms for PyTorch.
This only happens on one of my machines. It does not happen in our CI machines. Could just be a me-problem. Repro: ``` import torch from functorch import vmap x...
Initially reported by @michaelarbel here: https://github.com/pytorch/functorch/pull/620 make_functional with parameter sharing, where the parameter sharing happens by assigning a list of parameters to a module, doesn't work. Repro from @michaelarbel: ```...
https://github.com/pytorch/functorch/blob/main/functorch/_src/monkey_patching.py This is a holdover from our early prototype days. It makes us not composable with other libraries (see https://github.com/pytorch/torchdynamo/issues/440)
OpInfos provide error inputs. We should ensure that under all of our transforms, the error inputs still error out gracefully (rather than crash).
e.g., delete LegacyVmapTransforms.h and LegacyBatchingRegistrations.h The batching rules defined in LegacyBatchingRegistrations.h need to be migrated to the new-style batching rule API
## Motivation Currently, we only test the following compositions: - vmap - jvp - vjp - vmap x jvp - vmap x vjp - vjp x vjp - vjp x...
Given an OpInfo, functorch doesn't test aliases. That is, we test torch.abs, but not torch.absolute ## Pitch Aliases only appear in the forward pass, so we only really need to...
functorch's OpInfo-based tests skip in-place operations (those are tested elsewhere). We should try to come up with tests for the in-place operations.
Tracking bug for short-term fix for https://github.com/pytorch/functorch/pull/794 @eellison has been working on implementing a better fix in PyTorch core.
@Chillee One thing I am little skeptical about this is that - I could not come up with a handwritten testcase where the output `requires_grad` is `True` and `grad_state` is...