functorch icon indicating copy to clipboard operation
functorch copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

Delete monkeypatching

Open zou3519 opened this issue 3 years ago • 1 comments

https://github.com/pytorch/functorch/blob/main/functorch/_src/monkey_patching.py

This is a holdover from our early prototype days.

It makes us not composable with other libraries (see https://github.com/pytorch/torchdynamo/issues/440)

zou3519 avatar Jun 22 '22 15:06 zou3519

https://github.com/pytorch/functorch/pull/901 deletes the cross_entropy monkey patch. The other monkeypatches need some work in PyTorch core

zou3519 avatar Jun 22 '22 15:06 zou3519

Merged

zou3519 avatar Sep 22 '22 19:09 zou3519