executorch
executorch copied to clipboard
Always run extract sources on CMake configure
Always re-generate sources (via extract_sources) when running cmake configure. This is done to resolve T185463079. Note that this does not impact iterative builds, which still work fine. This change prevents the source list in the cmake build directory from becoming stale if the buck target sources change.
Test Plan:
(rm -rf cmake-out && mkdir cmake-out && cd cmake-out && cmake ..)
cmake --build cmake-out --target executor_runner -j9
(cd cmake-out && cmake ..)
cmake --build cmake-out --target executor_runner -j9
(rm -rf cmake-out && mkdir cmake-out && cd cmake-out && cmake -DEXECUTORCH_SRCS_FILE=mysources.cmake ..)
# Confirmed that cmake build used mysources.cmake
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3295
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:x: 9 New Failures, 1 Unrelated Failure
As of commit 2a789213783ec3a3b9a204d3756935d0b7971ec9 with merge base 2c00ade46e471f4a33929f5442c4ef7e773cf43b ():
NEW FAILURES - The following jobs have failed:
- pull / test-binary-size-linux / linux-job (gh)
RuntimeError: Command docker exec -t 7a8a4f4331573b4d42d3ea9b7d0afafffb6938579d375e700ccedc535cd33ac5 /exec failed with exit code 1 - pull / test-binary-size-linux-gcc / linux-job (gh)
RuntimeError: Command docker exec -t 874f1b6943a7a091e642920c24f50b47e4a40e9c4ada1ce07f0547f7d2c74e04 /exec failed with exit code 1 - pull / test-custom-ops-linux (cmake) / linux-job (gh)
RuntimeError: Command docker exec -t f14a44ce6f3855caec12e9606835f40acff9d5efdde84544e18f57d20c54e526 /exec failed with exit code 1 - pull / test-llama-runner-linux (fp32, cmake, portable) / linux-job (gh)
RuntimeError: Command docker exec -t faa38edcdab22cc3a805965313a481ae1ebc94253f5f807dd55ea41b7b911a06 /exec failed with exit code 1 - pull / test-llama-runner-linux (fp32, cmake, xnnpack+custom) / linux-job (gh)
RuntimeError: Command docker exec -t cdbd429eb0973a8eb6909673c86019e88cba60b35c110bf0c7a23077907e0cc5 /exec failed with exit code 1 - pull / test-llama-runner-linux (fp32, cmake, xnnpack+custom+qe) / linux-job (gh)
RuntimeError: Command docker exec -t 589b764fad136e31c6677b82d2e534c284fcb267cb1c4ea6a62aa67b36a6ccd9 /exec failed with exit code 1 - trunk / test-custom-ops-macos (cmake) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1 - trunk / test-llama-runner-mac (fp32, cmake, portable) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1 - trunk / test-llama-runner-mac (fp32, cmake, xnnpack+kv+custom) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
- trunk / test-coreml-delegate / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
This pull request was exported from Phabricator. Differential Revision: D56508164