executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Always run extract sources on CMake configure

Open GregoryComer opened this issue 1 year ago • 2 comments

Always re-generate sources (via extract_sources) when running cmake configure. This is done to resolve T185463079. Note that this does not impact iterative builds, which still work fine. This change prevents the source list in the cmake build directory from becoming stale if the buck target sources change.

Test Plan:

(rm -rf cmake-out && mkdir cmake-out && cd cmake-out && cmake ..)
cmake --build cmake-out --target executor_runner -j9
(cd cmake-out && cmake ..)
cmake --build cmake-out --target executor_runner -j9
(rm -rf cmake-out && mkdir cmake-out && cd cmake-out && cmake -DEXECUTORCH_SRCS_FILE=mysources.cmake ..)
# Confirmed that cmake build used mysources.cmake

GregoryComer avatar Apr 24 '24 07:04 GregoryComer

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3295

Note: Links to docs will display an error until the docs builds have been completed.

:x: 9 New Failures, 1 Unrelated Failure

As of commit 2a789213783ec3a3b9a204d3756935d0b7971ec9 with merge base 2c00ade46e471f4a33929f5442c4ef7e773cf43b (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 24 '24 07:04 pytorch-bot[bot]

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 24 '24 07:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56508164

facebook-github-bot avatar Jun 03 '24 21:06 facebook-github-bot