executorch
executorch copied to clipboard
Fix portable is[inf|nan|_out compilation on older Linux
Follow up after https://github.com/pytorch/executorch/pull/3262 that didn't actually solved the problem..
By wrapping a potentially non-compliant isinf/isnan implementations into a lambda with a defined return type
Compiler should be able to optimize it out into direct function call, see https://godbolt.org/z/bqYGd47Mx
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3272
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:white_check_mark: No Failures
As of commit 8a7986c797cbdd1ce120f3283b99e3b624a6d0e3 with merge base b7b40ac67adf882e8cf50d85edbb55e5709a9694 ():
:green_heart: Looks good so far! There are no failures yet. :green_heart:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@malfet merged this pull request in pytorch/executorch@e25e5d25cfe272f0aefb6205d8f258f3928dcbfb.