executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Fix portable is[inf|nan|_out compilation on older Linux

Open malfet opened this issue 1 year ago • 2 comments

Follow up after https://github.com/pytorch/executorch/pull/3262 that didn't actually solved the problem.. By wrapping a potentially non-compliant isinf/isnan implementations into a lambda with a defined return type

Compiler should be able to optimize it out into direct function call, see https://godbolt.org/z/bqYGd47Mx

malfet avatar Apr 24 '24 03:04 malfet

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3272

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 8a7986c797cbdd1ce120f3283b99e3b624a6d0e3 with merge base b7b40ac67adf882e8cf50d85edbb55e5709a9694 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 24 '24 03:04 pytorch-bot[bot]

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 24 '24 03:04 facebook-github-bot

@malfet merged this pull request in pytorch/executorch@e25e5d25cfe272f0aefb6205d8f258f3928dcbfb.

facebook-github-bot avatar Apr 24 '24 15:04 facebook-github-bot