executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Update method name for tester

Open digantdesai opened this issue 1 year ago • 6 comments

Summary: Method name update

Differential Revision: D56072265

digantdesai avatar Apr 12 '24 19:04 digantdesai

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3016

Note: Links to docs will display an error until the docs builds have been completed.

:x: 2 New Failures, 3 Unrelated Failures

As of commit 38d04b667534f50643c0de083a9ae51a3b1f2e84 with merge base 057e432282c2a9263c903cf0a10769689c7de676 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 12 '24 19:04 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D56072265

facebook-github-bot avatar Apr 12 '24 19:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56072265

facebook-github-bot avatar Apr 12 '24 19:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56072265

facebook-github-bot avatar Apr 15 '24 15:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56072265

facebook-github-bot avatar Apr 15 '24 15:04 facebook-github-bot

LGTM, but I have fixed the issues in a slightly different way in https://github.com/pytorch/executorch/pull/2991. I'd prefer that since it's using the new and shiny method

freddan80 avatar Apr 15 '24 15:04 freddan80