pytorch
Check for null outputs in method
Summary: When non-memory-planned outputs are unset, method execution will crash when writing to the output tensor. This manifests as a native crash with a deep stack trace that is both unrecoverable and unclear to the user. This PR adds a check in method.execute to detect null output tensor data pointers, and, if found, log a message and return an error code.
Differential Revision: D78438716
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12559
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:x: 2 New Failures
As of commit d2635e59a0a89acec276515670887799193ceba5 with merge base 1333b36ab307dff4b7abe2516c2e6cca84e97edf (
NEW FAILURES - The following jobs have failed:
- pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t 3283db27f21d9d0811196237b4486655b05f116739eeb59606d8b6463abe18af /exec failed with exit code 1 - pull / unittest-nxp-neutron / linux-job (gh)
RuntimeError: Command docker exec -t 3190781c8475901232584637db954647cf2206c292fe0b7bf303060504d46188 /exec failed with exit code 1
This comment was automatically generated by Dr. CI and updates every 15 minutes.
![pytorch-bot[bot] avatar](https://avatars.githubusercontent.com/in/40112?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.Stale pull requests will automatically be closed after 30 days of inactivity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.Stale pull requests will automatically be closed after 30 days of inactivity.