executorch icon indicating copy to clipboard operation
executorch copied to clipboard

[ET-VK] 6/n Split dispatches between multiple command buffers. Repurpose submit_current_cmd_and_wait to wait based on input flag.

Open trivedivivek opened this issue 5 months ago • 6 comments

Stack from ghstack (oldest at bottom):

  • #12530
  • -> #12529
  • #12527
  • #12525
  • #12523
  • #12522
  • #12519

This diff makes changes to the submit_current_cmd_and_wait function in the ComputeGraph class to repurpose it to wait for command buffer completion based on an input flag. The function is renamed to submit_current_cmd and now takes an additional wait parameter. If wait is true, the function submits the command buffer to the GPU and waits for its completion. Otherwise, it only submits the command buffer without waiting.

Differential Revision: D78360042

trivedivivek avatar Jul 15 '25 23:07 trivedivivek

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12529

Note: Links to docs will display an error until the docs builds have been completed.

:x: 2 New Failures, 2 Unrelated Failures

As of commit c103fd7b8a17402e36025428e5b7520144e60a07 with merge base 4551a56a454bb6160f9e091e115f068e4c3357bc (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jul 15 '25 23:07 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D78360042

facebook-github-bot avatar Jul 15 '25 23:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D78360042

facebook-github-bot avatar Jul 15 '25 23:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D78360042

facebook-github-bot avatar Jul 16 '25 14:07 facebook-github-bot

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Sep 15 '25 00:09 github-actions[bot]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Nov 15 '25 00:11 github-actions[bot]