cpuinfo icon indicating copy to clipboard operation
cpuinfo copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

cpuinfo_x86_normalize_brand_string

Open fbarchard opened this issue 1 year ago • 1 comments

Fix cpuinfo_x86_normalize_brand_string unannotated fall-through warning

fbarchard avatar Feb 26 '24 23:02 fbarchard

The issue was reported as XNNPack not building with the -Wimplicit-fallthrough flag https://github.com/google/XNNPACK/issues/6047 But when I apply the flag in XNNPack build the pytorch/cpuinfo has 2 build warnings. The first was a legitimate bug and fixed in https://github.com/pytorch/cpuinfo/pull/225 This one is not a bug, but the other cases are handled the same was as this PR.

XNNPack requires C11 but can work on VS2012 or GCC 4.9. If this PR is taken, x86 builds cleanly, but for ARM are more, but I didnt spot legitimate bugs, so I wasnt going to do the fallthru directives.

fbarchard avatar Feb 29 '24 09:02 fbarchard