ao icon indicating copy to clipboard operation
ao copied to clipboard

Building from source caused uint issue + suggested fix

Open EnragedAntelope opened this issue 1 year ago • 2 comments

Hi, I was on torchao 0.1. When I used pip install --upgrade torchao, it kept me on 0.1 for some reason.

So I built from source, but wanted to let you know I encountered this error initially:

D:\ao\torchao\csrc\cuda\sparse_marlin\base.h(47): error: identifier "uint" is undefined

  using FragM = Vec<uint, 1>;
                    ^

I asked Claude to review, and it gave me a working solution:


1. Contact the package maintainers:
If this is a public package, you could report this issue to the maintainers of the torchao package. They might need to update their code to use unsigned int instead of uint, or properly include the necessary header that defines uint.

2. Modify the source code:
Open the file D:\ao\torchao\csrc\cuda\sparse_marlin\base.h
Find line 47 (or thereabouts)
Change uint to unsigned int

Just making you aware in case that change should be made for all.

Thank you!

EnragedAntelope avatar Sep 26 '24 14:09 EnragedAntelope

cc @EnragedAntelope

Thanks for flagging, could you open a PR to make those changes? Feel free to tag me for review :)

jcaip avatar Sep 26 '24 20:09 jcaip

Thank you. I tried and I would love to move it forward to you but I can't believe how much personal information it wants me to populate... have not encountered this before for a simple PR.

EnragedAntelope avatar Sep 28 '24 02:09 EnragedAntelope

Closing it as the issue doesn't exist anymore

jainapurva avatar Mar 11 '25 04:03 jainapurva