ao icon indicating copy to clipboard operation
ao copied to clipboard

Add analysis of FP8 + activation checkpointing memory issue

Open djmatusz-lambda opened this issue 1 month ago • 2 comments

  • Identified root cause: FP8 implementation unaware of checkpointing context
  • FP8 always saves HP tensors, conflicting with checkpointing memory savings
  • Documented issue in float8_linear.py matmul_with_hp_or_float8_args function
  • Proposed solution with checkpointing context detection
  • Includes implementation plan and expected benefits

djmatusz-lambda avatar Nov 17 '25 23:11 djmatusz-lambda

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3349

Note: Links to docs will display an error until the docs builds have been completed.

:x: 1 New Failure

As of commit ade779e2cd4978831a5c40789b7edf7947639b7d with merge base e1102278e1d16e61492c822633de6d9b207ec834 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Nov 17 '25 23:11 pytorch-bot[bot]

Hi @djmatusz-lambda!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

meta-cla[bot] avatar Nov 17 '25 23:11 meta-cla[bot]