ao icon indicating copy to clipboard operation
ao copied to clipboard

[BC] Make awq test better parallel execution

Open namgyu-youn opened this issue 2 months ago • 6 comments

summary: Update AWQ tests to enable parallel execution by parametrizing device-config pairs. This update doesn't break BC.

test plan: test/prototype/test_awq.py

namgyu-youn avatar Oct 10 '25 06:10 namgyu-youn

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3143

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Oct 10 '25 06:10 pytorch-bot[bot]

@pytorchbot label "topic: not user facing"

namgyu-youn avatar Nov 09 '25 07:11 namgyu-youn

CI failed to build, probably re-run? This issue have been observed multiple times.

namgyu-youn avatar Nov 18 '25 11:11 namgyu-youn

can you rebase to trigger the CI again

jerryzh168 avatar Nov 20 '25 05:11 jerryzh168

can you rebase to trigger the CI again

Added empty commit and rebased to trigger CI, please take a look.

namgyu-youn avatar Nov 20 '25 08:11 namgyu-youn

@pytorchbot merge

namgyu-youn avatar Dec 10 '25 05:12 namgyu-youn

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

  • Facebook CLA Check

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: superuser

pytorchmergebot avatar Dec 10 '25 05:12 pytorchmergebot

@facebook-github-bot recheck

namgyu-youn avatar Dec 10 '25 06:12 namgyu-youn

@pytorchbot help

namgyu-youn avatar Dec 10 '25 06:12 namgyu-youn

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'help' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

pytorch-bot[bot] avatar Dec 10 '25 06:12 pytorch-bot[bot]

@pytorchbot --help

namgyu-youn avatar Dec 10 '25 06:12 namgyu-youn

PyTorchBot Help

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

In order to invoke the bot on your PR, include a line that starts with
@pytorchbot anywhere in a comment. That line will form the command; no
multi-line commands are allowed. Some commands may be used on issues as specified below.

Example:
    Some extra context, blah blah, wow this PR looks awesome

    @pytorchbot merge

optional arguments:
  -h, --help            Show this help message and exit.

command:
  {merge,revert,rebase,label,drci,cherry-pick}
    merge               Merge a PR
    revert              Revert a PR
    rebase              Rebase a PR
    label               Add label to a PR
    drci                Update Dr. CI
    cherry-pick         Cherry pick a PR onto a release branch

Merge

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Merge an accepted PR, subject to the rules in .github/merge_rules.json.
By default, this will wait for all required checks (lint, pull) to succeed before merging.

optional arguments:
  -f MESSAGE, --force MESSAGE
                        Merge without checking anything. This requires a reason for auditting purpose, for example:
                        @pytorchbot merge -f 'Minor update to fix lint. Expecting all PR tests to pass'
                        
                        Please use `-f` as last resort, prefer `--ignore-current` to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.
  -i, --ignore-current  Merge while ignoring the currently failing jobs.  Behaves like -f if there are no pending jobs.
  -ic                   Old flag for --ignore-current. Deprecated in favor of -i.
  -r [{viable/strict,main}], --rebase [{viable/strict,main}]
                        Rebase the PR to re run checks before merging.  Accepts viable/strict or main as branch options and will default to viable/strict if not specified.

Revert

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst,autorevert}

Revert a merged PR. This requires that you are a Meta employee.

Example:
  @pytorchbot revert -m="This is breaking tests on trunk. hud.pytorch.org/" -c=nosignal

optional arguments:
  -m MESSAGE, --message MESSAGE
                        The reason you are reverting, will be put in the commit message. Must be longer than 3 words.
  -c {nosignal,ignoredsignal,landrace,weird,ghfirst,autorevert}, --classification {nosignal,ignoredsignal,landrace,weird,ghfirst,autorevert}
                        A machine-friendly classification of the revert reason.

Rebase

usage: @pytorchbot rebase [-s | -b BRANCH]

Rebase a PR. Rebasing defaults to the stable viable/strict branch of pytorch.
Repeat contributor may use this command to rebase their PR.

optional arguments:
  -s, --stable          [DEPRECATED] Rebase onto viable/strict
  -b BRANCH, --branch BRANCH
                        Branch you would like to rebase to

Label

usage: @pytorchbot label labels [labels ...]

Adds label to a PR or Issue [Can be used on Issues]

positional arguments:
  labels  Labels to add to given Pull Request or Issue [Can be used on Issues]

Dr CI

usage: @pytorchbot drci 

Update Dr. CI. Updates the Dr. CI comment on the PR in case it's gotten out of sync with actual CI results.

cherry-pick

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Cherry pick a pull request onto a release branch for inclusion in a release

optional arguments:
  --onto ONTO, --into ONTO
                        Branch you would like to cherry pick onto (Example: release/2.1)
  --fixes FIXES         Link to the issue that your PR fixes (Example: https://github.com/pytorch/pytorch/issues/110666)
  -c {regression,critical,fixnewfeature,docs,release}, --classification {regression,critical,fixnewfeature,docs,release}
                        A machine-friendly classification of the cherry-pick reason.

pytorch-bot[bot] avatar Dec 10 '25 06:12 pytorch-bot[bot]

@pytorchmergebot merge

namgyu-youn avatar Dec 10 '25 06:12 namgyu-youn

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

  • Facebook CLA Check

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: superuser

pytorchmergebot avatar Dec 10 '25 06:12 pytorchmergebot

@pytorchbot merge --rebase

namgyu-youn avatar Dec 10 '25 06:12 namgyu-youn

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

  • Facebook CLA Check

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: superuser

pytorchmergebot avatar Dec 10 '25 06:12 pytorchmergebot

@pytorchbot drci

namgyu-youn avatar Dec 10 '25 06:12 namgyu-youn

@jerryzh168 hope to remember this PR, could you please look into it? I have been waited with rebase, and this PR allows parallel execution unit test for AWQ.

namgyu-youn avatar Dec 19 '25 05:12 namgyu-youn