ao icon indicating copy to clipboard operation
ao copied to clipboard

Add quantized embedding kernels to torchao

Open metascroy opened this issue 1 year ago • 11 comments

Summary: This diff adds lowbit embedding kernels to torchao. These reuse the same bitpacking code as the linear kernels.

Differential Revision: D63839255

metascroy avatar Oct 04 '24 19:10 metascroy

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1018

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 2169c3225bd6d25a4a4fbaaacbaf00edbd8388ce with merge base 7aaf0ff979b8e254b0c55cb8353ce5a73c7c257f (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Oct 04 '24 19:10 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 04 '24 19:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 04 '24 20:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 04 '24 21:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 07 '24 15:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 07 '24 15:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 08 '24 00:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 08 '24 00:10 facebook-github-bot

@jerryzh168 if things look good to you, can you approve the diff too D63839255

metascroy avatar Oct 08 '24 19:10 metascroy

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 11 '24 20:10 facebook-github-bot

@metascroy I'm mostly just stamping the ao/experimental PR, do you need a proper review or just stamps for the diff?

jerryzh168 avatar Oct 12 '24 01:10 jerryzh168

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 15 '24 17:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 15 '24 17:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 15 '24 23:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 16 '24 16:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 16 '24 20:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 16 '24 20:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 17 '24 18:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 17 '24 18:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63839255

facebook-github-bot avatar Oct 17 '24 20:10 facebook-github-bot