TensorRT icon indicating copy to clipboard operation
TensorRT copied to clipboard

ci: Add release flag for nightly build tag

Open gs-olive opened this issue 1 year ago • 2 comments

Description

  • As is added in #2806 for C++ builds, enable --release flag for builds in main to enable correct nightly versioning on PyTorch index

Type of change

  • Address CI Issue

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

gs-olive avatar May 07 '24 22:05 gs-olive

wheel-build-params is a bit special. It only has an effect when env-script is also specified. We don't necessarily have to use --release flag here, since setup.py also checks RELEASE env var. So I made the relevant changes.

HolyWu avatar May 08 '24 13:05 HolyWu

@HolyWu - thanks for this detail. I wanted to add the release specification to the nightly builds in advance of getting your PR #2806 merged, and to get this change to another branch which only has the Python runtime for Windows. I can cherry-pick your env var commit 6b7a9e00fe75b449 into this PR instead

Update: Cherry-picked and reformatted the change to only include the environment variable insertion to get main and release/2.3 updated in advance of #2806 getting merged

gs-olive avatar May 08 '24 20:05 gs-olive